-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Area estimation from multiple land cover product #391
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend moving this inside the maps/Kenya_2019
folder. I think its only used there and will be easier to find that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted!
@@ -0,0 +1,644 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Google Colab for now.
I'll add modifications for local later.
@adebowaledaniel It seems like the goal of this PR is similar to my other PR #374. Have you reviewed that PR already? Can you comment on how the goals of this are different from that PR, or do you see this as superseding the other PR? |
@hannah-rae, The primary goal of this PR is to get the area estimates of a reference year from all the land cover products available for that year, including the ones ± 2 years. So, my focus was on the area estimation. I didn't notice #374 until I finished this draft. I suggest we complete and merge #374 first. Or integrate both PRs since this has an extra layer for area estimates. |
The
src/compare_covermaps
module already provided all necessary functions and classes to support area estimation from multiple land cover maps. However, there is no provision to select maps available for a year of interest, which is important for crop area estimation. So, I modified the module and updated the intercomparison notebook template to include the area estimates in the PR.year
variable to theCovermap
class. This is needed to select land cover maps available for the reference year and add year attributes to each map in the module.DynamicWorld
dataset returns a None array due to EEcomputation timed out
. [Temporarily fix] - I changed the None array to nan to avoid errors in the notebook.