Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run RPI integration tests for LedBlinker #2264

Merged
merged 21 commits into from
Oct 25, 2023
Merged

Run RPI integration tests for LedBlinker #2264

merged 21 commits into from
Oct 25, 2023

Conversation

thomas-bc
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) #2102
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Adds a workflow to run integration tests on raspberrypi for https://github.com/fprime-community/fprime-workshop-led-blinker

Some notes:

  • I didn't really find anything that was generic or complex enough to warrant abstracting things away in a reusable workflow/action. Although Run CI on UH Cubesat #2203 may reveal a need
  • I'm opening this as a draft for now to wait on the above-mentioned issue and whether things need changing

@thomas-bc
Copy link
Collaborator Author

thomas-bc commented Aug 31, 2023

Integration tests currently fail because fprime-workshop-led-blinker:devel does not include the call to .startup() (and shutdown) even though it switched to using TcpServer. This wasn't caught because we're not running integration tests on this repo... which this PR will fix!
Although, it might be worth simply waiting for #2261 to be merged, which removes the need to explicitly call .startup() for TcpServer.

@thomas-bc thomas-bc marked this pull request as ready for review October 24, 2023 22:36
@thomas-bc thomas-bc closed this Oct 24, 2023
@thomas-bc thomas-bc reopened this Oct 24, 2023
@LeStarch
Copy link
Collaborator

Merge it merge it!

@LeStarch LeStarch merged commit 34f0287 into devel Oct 25, 2023
35 checks passed
@thomas-bc thomas-bc deleted the rpi-ledblinker branch October 25, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants