-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version check command #190
Conversation
I also added a skeleton unit test for commands (as asked above in the PR), it's pretty empty as of now but I would be happy to write tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you very much!
Looks good to me - just requesting a couple of very minor changes on formatting etc...
Also make sure to take a look at the spellings that were flagged by CI and to add them in https://github.com/0x48piraj/fprime-tools/blob/fd5add0f8781825ea90bfccdcd8d3fb1872d36b2/.github/actions/spelling/expect.txt if they are false positives.
Looks like you also need to run the formatter -
I figured you might want to take this across the finish line yourself, but let me know if you want me to help make some changes. |
All the requested changes were made including the unused import one and it works as intended in local settings. |
Thanks! Note to myself: add OS and processor architecture information as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits, but this is great work!
Rather than using sys, I utilized the |
Any updates on this @thomas-bc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Apologies for the delay, I was out for a bit. LGTM! Thank you very much for this, we want to add this command to our bug_report.md issue template over on https://github.com/nasa/fprime. Feel free to make the PR yourself there if you want to! e.g. add a section/checkmark
|
Change Description
Adds a version check command for
Rationale
Help debug things
Future Work
Unit tests preferably.