Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 support #175

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Sunsetting Python 3.7 support

Rationale

Python 3.7 came to end of life: https://endoflife.date/python
Support has been dropped on https://github.com/nasa/fprime

# Requires Python 3.7+
python_requires=">=3.7",
# Requires Python 3.8+
python_requires=">=3.8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this change?
This may cause confusion for users, as pip install fprime-tools will install older versions without warning if running Python 3.7. But I don't think there is a better solution. The alternative is to keep it in, which may cause errors when running pip install.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we break the bootstrapping script into its own entity that can support multiple versions of python and users of (deprecated) 3.7 could then install older versions of F´  with supported packages.

@thomas-bc thomas-bc mentioned this pull request Oct 30, 2023
@thomas-bc thomas-bc merged commit a456240 into nasa:devel Oct 30, 2023
24 checks passed
@thomas-bc thomas-bc deleted the require-python-38 branch October 30, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants