Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parallel builds #173

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fixing parallel builds #173

merged 1 commit into from
Oct 24, 2023

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Oct 24, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fixes the parallel build -jN flag passing. This has been broken since at least v3.0.0.

Rationale

Builds should be fast

Testing/Review Recommendations

  • Tested fprime-util build -j16
  • Tested fprime-util check -j16

Much faster.

Future Work

None

@LeStarch
Copy link
Collaborator Author

An explanation of the fix:

The job flag may be supplied to any target in make, however "all targets" were objects and the "command" was a string. This checks against the mnemonic flags instead.

@LeStarch LeStarch merged commit 9bb39c1 into nasa:devel Oct 24, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants