Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUMULUS-3759:Migrated ECS Autoscaling group from launch configurations to launch templates #3880

Merged
merged 16 commits into from
Dec 19, 2024
Merged

CUMULUS-3759:Migrated ECS Autoscaling group from launch configurations to launch templates #3880

merged 16 commits into from
Dec 19, 2024

Conversation

jennyhliu
Copy link
Contributor

@jennyhliu jennyhliu commented Dec 10, 2024 •
edited
Loading

Summary: Summary of changes

Addresses CUMULUS-3759: Migrated ECS Autoscaling group from launch configurations to launch templates

Changes

  • Migrated tf-modules/cumulus/ecs_cluster ECS Autoscaling group from launch configurations to launch templates
  • Added cumulus-std to ci configuration

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

jennyhliu
jennyhliu commented Dec 16, 2024
View reviewed changes
example/config.yml Outdated Show resolved Hide resolved
@jennyhliu jennyhliu marked this pull request as ready for review December 16, 2024 18:39
Nnaga1
Nnaga1 reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Nnaga1 Nnaga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jenny, just some questions for you, I'm going to try to deploy this branch also 🙌 I don't really have any requested changes just questions 👍

example/config.yml Outdated Show resolved Hide resolved
example/fake-provider-cf.yml Show resolved Hide resolved
example/deployments/cumulus/cumulus-std.tfvars Outdated Show resolved Hide resolved
tf-modules/cumulus/ecs_cluster.tf Show resolved Hide resolved
tf-modules/cumulus/ecs_cluster.tf Show resolved Hide resolved
tf-modules/cumulus/ecs_cluster.tf Show resolved Hide resolved
tf-modules/cumulus/ecs_cluster.tf Show resolved Hide resolved
tf-modules/cumulus/ecs_cluster_instance_autoscaling_user_data.tmpl Outdated Show resolved Hide resolved
Nnaga1
Nnaga1 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Nnaga1 Nnaga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering my questions, I deployed and checked and it looks good! Great work as always 🎈

@Nnaga1 Nnaga1 removed the in review label Dec 18, 2024
@jennyhliu jennyhliu merged commit bae3a87 into master Dec 19, 2024
3 checks passed
@jennyhliu jennyhliu deleted the jl/CUMULUS-3759 branch December 19, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nnaga1 Nnaga1 Nnaga1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyhliu @Nnaga1