Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #422, implement dispatcher pattern for CF #426

Merged
merged 1 commit into from
Jan 11, 2024

Fix #422, implement dispatcher pattern for CF

989274c
Select commit
Loading
Failed to load commit list.
Merged

Fix #422, implement dispatcher pattern for CF #426

Fix #422, implement dispatcher pattern for CF
989274c
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL-coding-standard succeeded Dec 15, 2023 in 3s

22 new alerts

New alerts in code changed by this pull request

  • 22 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 810 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

CF_WriteQueueCmd has too many lines (129, while 60 are allowed).

Check notice on line 64 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

CF_ResetCmd has too many lines (63, while 60 are allowed).

Check notice on line 42 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

CF_ProcessGroundCommand has too many lines (83, while 60 are allowed).

Check notice on line 44 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Hidden pointer indirection Note

The typedef handler_fn_t hides pointer indirection.

Check notice on line 107 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Use of non-constant function pointer Note

This call does not go through a const function pointer.

Check notice on line 1198 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 1166 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 810 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 786 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 682 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 655 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 598 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 573 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 536 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 501 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 306 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 282 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 183 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 134 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 64 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 42 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 132 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.