Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3351 Integrate and validate the use of UMM-Vis to test in Worldview #5549

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

PatchesMaps
Copy link
Contributor

Description

Refactor layer metadata retrieval and rendering

  • Update features.json to include cmrVisualizationsUrl
  • Modify getVisMetadata.js to fetch metadata from cmrVisualizationsUrl if available
  • Update renderSplitTitle.js and selectors.js to handle title and subtitle properties in different cases

How To Test

  • git checkout WV-3351-umm-vis-test
  • npm i && npm run build:verbose
  • Confirm that the app behaves normally
  • You can use layer "VIIRS_SNPP_DayNightBand_AtSensor_M15" as a test case.

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

- Update features.json to include cmrVisualizationsUrl
- Modify getVisMetadata.js to fetch metadata from cmrVisualizationsUrl if available
- Update renderSplitTitle.js and selectors.js to handle title and subtitle properties in different cases
@PatchesMaps PatchesMaps self-assigned this Nov 1, 2024
@PatchesMaps PatchesMaps marked this pull request as draft November 1, 2024 20:38
@minniewong
Copy link
Contributor

Screenshot 2024-11-04 at 4 12 11 PM
I don't get the correct titles for the layers

@minniewong
Copy link
Contributor

Screenshot 2024-11-04 at 4 13 49 PM
No titles display at all from the "Add Layers". Also "Add Layers" seems a little sluggish, it takes a while to click on a measurement and it to do something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants