feat: track whether expressions change length but don't aggregate, and only allow length-changing expressions if they're followed by aggregations in the lazy API #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jan 19, 2025
Comment on lines
+43
to
+44
| with pytest.raises(LengthChangingExprError): | ||
| df.select((nw.col("a").unique() + nw.col("b").unique()).sum()) |
There was a problem hiding this comment.
an expression like this is so bizarre that I doubt we'd be cutting off many real use-cases...
FBruzzesi
reviewed
Jan 19, 2025
There was a problem hiding this comment.
Thanks @MarcoGorelli ! This was easier to go through than expected 🚀
I left only a couple of comments but I wonder about other edge cases 🤔
Comment on lines
+43
to
+44
| with pytest.raises(LengthChangingExprError): | ||
| df.select((nw.col("a").unique() + nw.col("b").unique()).sum()) |
|
thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting closer to stable.v2
Similar to #743
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below