chore: simplify internal renaming in _pandas_like/series.py (#1847)

chore: simplify _pandas_like/series.py renaming
narwhals-dev · Jan 21, 2025 · a11843f · a11843f
1 parent 38fadec
commit a11843f
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 250 deletions.
diff --git a/narwhals/_pandas_like/namespace.py b/narwhals/_pandas_like/namespace.py
@@ -18,7 +18,6 @@
 from narwhals._pandas_like.utils import create_compliant_series
 from narwhals._pandas_like.utils import diagonal_concat
 from narwhals._pandas_like.utils import horizontal_concat
-from narwhals._pandas_like.utils import rename
 from narwhals._pandas_like.utils import vertical_concat
 from narwhals.typing import CompliantNamespace
 from narwhals.utils import import_dtypes_module
@@ -267,18 +266,13 @@ def func(df: PandasLikeDataFrame) -> list[PandasLikeSeries]:
 
             return [
                 PandasLikeSeries(
-                    native_series=rename(
-                        self.concat(
-                            (s.to_frame() for s in series), how="horizontal"
-                        )._native_frame.min(axis=1),
-                        series[0].name,
-                        implementation=self._implementation,
-                        backend_version=self._backend_version,
-                    ),
+                    self.concat(
+                        (s.to_frame() for s in series), how="horizontal"
+                    )._native_frame.min(axis=1),
                     implementation=self._implementation,
                     backend_version=self._backend_version,
                     version=self._version,
-                )
+                ).alias(series[0].name)
             ]
 
         return self._create_expr_from_callable(
@@ -298,18 +292,13 @@ def func(df: PandasLikeDataFrame) -> list[PandasLikeSeries]:
 
             return [
                 PandasLikeSeries(
-                    rename(
-                        self.concat(
-                            (s.to_frame() for s in series), how="horizontal"
-                        )._native_frame.max(axis=1),
-                        series[0].name,
-                        implementation=self._implementation,
-                        backend_version=self._backend_version,
-                    ),
+                    self.concat(
+                        (s.to_frame() for s in series), how="horizontal"
+                    )._native_frame.max(axis=1),
                     implementation=self._implementation,
                     backend_version=self._backend_version,
                     version=self._version,
-                )
+                ).alias(series[0].name)
             ]
 
         return self._create_expr_from_callable(