Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README #365

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Update the README #365

merged 12 commits into from
Nov 7, 2024

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Nov 2, 2024

This PR updates the README.md to be more user-friendly. The PR:

  • adds description of project
  • reframes documentation section into getting started for user and developer personas
  • adds explicit installation instructions for npe2 for pip and conda
  • updates the CLI commands and examples
  • adds a license section
  • moves the historical content to the end
  • adds Contact us section

I was trying to understand the technical architecture of the plugin engine and created this to help me with my own understanding. Thought it might be helpful for others too.

Closes #263.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4f845f9) to head (2930561).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2757      2757           
=========================================
  Hits          2757      2757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Really great overhaul, thanks!
❤️

README.md Outdated Show resolved Hide resolved
Co-authored-by: Peter Sobolewski <[email protected]>
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @willingc, thank you for the massive improvement! I left a couple of comments 😊

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

1. Create and activate a virtual environment.

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think it's better to link here to our virtual environments guide: https://napari.org/stable/plugins/virtual_environment_docs/1-virtual-environments.html

I can see how we might just want a quickstart so feel free to take or leave this suggestion!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this. Let's add the documentation link below the quickstart commands.

In general, I like to keep all installation steps together instead of linking out to other docs. Installation is the first experience users have with the repo, and we want them to be successful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an italicized note to with the suggested guide. 👍🏼

README.md Show resolved Hide resolved
@willingc
Copy link
Contributor Author

willingc commented Nov 6, 2024

Thanks for the review @DragaDoncila. I've incorporated your suggestions. ☀️

README.md Outdated Show resolved Hide resolved
Co-authored-by: Peter Sobolewski <[email protected]>
@psobolewskiPhD psobolewskiPhD added the ready to merge Last chance for comments! Will be merged in ~24h label Nov 6, 2024
@DragaDoncila DragaDoncila merged commit de7262c into napari:main Nov 7, 2024
34 checks passed
@DragaDoncila DragaDoncila removed the ready to merge Last chance for comments! Will be merged in ~24h label Nov 7, 2024
@willingc willingc deleted the polish-readme branch November 8, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve description and information on README
3 participants