Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change npe1 plugin used for sample data test #364

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

DragaDoncila
Copy link
Contributor

Closes #363 by changing the plugin used in the test to avoid name normalization issues entirely.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa6f67b) to head (9e506a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #364   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2757      2757           
=========================================
  Hits          2757      2757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DragaDoncila DragaDoncila requested review from jni and Czaki October 24, 2024 23:33
@jni
Copy link
Member

jni commented Oct 25, 2024

@DragaDoncila I think you should still normalise (use .replace('_', '-')) because nothing at all is stopping that package from updating in the same broken way.

@DragaDoncila
Copy link
Contributor Author

@jni if we want to normalise, I'm happy to, but I don't think randomly changing this single test is the way to do it. Or even changing every test for that matter.

I think we should get this in to fix CI, and then have a separate discussion about whether we want to normalise manifest names, and when.

@jni jni merged commit b94506f into napari:main Oct 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing due to test expecting package name with hyphens containing underscores instead
3 participants