Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch API to improve reliability #265

Closed
wants to merge 2 commits into from

Conversation

aganders3
Copy link
Contributor

This draft includes two proposed changes:

  1. Fetch available plugins via the PyPI XML-RPC API, which is generally much faster and seems more reliable than scraping, but is considered legacy and planned to be deprecated.
  2. Fallback on scraping as we do now, but with improved reliability by explicitly setting the ordering to "Date last updated" which results in more stable results.

See #262 for more discussion on whether the first is desirable - I will leave this as draft until that issue is resolved, but I think the second change should be incorporated either way.

@@ -26,6 +26,7 @@ install_requires =
PyYAML
appdirs
build
packaging
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. this is already a transitive dependency I think

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #265 (12c8093) into main (1c51f58) will decrease coverage by 0.07%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##              main     #265      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files           37       37              
  Lines         2814     2833      +19     
===========================================
+ Hits          2814     2831      +17     
- Misses           0        2       +2     
Impacted Files Coverage Δ
npe2/_inspection/_fetch.py 99.08% <92.30%> (-0.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aganders3 aganders3 closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant