This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Do not create special case for plugins named napari-foobar #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jni
approved these changes
Jun 6, 2024
|
Since the tests are passing, I suggest we just merge this. (Smells like a hacky testing workaround, but evidently obsolete.) I've merged main to the branch just in case but if the tests pass we should just merge. |
Czaki
approved these changes
Jun 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can anyone tell me why this special case was written in the first place?
Either we have a really good reason for it, and add comments explaining the need for this special situation,
OR
We remove the special case treatment, and handle all plugins the same way.