Add ModelInfo structure for kit 10.4.1 4kHz 260bps data #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, 260bps duplex is not something we've explicitly tested though I expect the 4kHz stereo model to work fine for it. Is this something you've tested and verified looks good? |
|
Hi @mp15 - thank you for the PR! Can you merge this change into |
mp15
force-pushed
the
reenable-260-stereo-calling
branch
2 times, most recently
from
813c5fc
to
832ae44
Compare
|
Rebased onto |
mp15
force-pushed
the
reenable-260-stereo-calling
branch
from
832ae44
to
940e392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the stereo model for 260 bps data @ 4kHz is the same as the model for 400 bps model. Unfortunately there is no way to explicitly specify duplex models and increased error checking means you cannot currently stereo basecall your 260 bps data. Therefore I suggest adding a ModelInfo so that this is again possible? If I've got this wrong please do point me in the right direction.