fixes #1496 Provide NNG_ENABLE_IPV6 option (disabled by default) #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1787 +/- ##
==========================================
- Coverage 79.28% 79.12% -0.17%
==========================================
Files 94 94
Lines 21077 21078 +1
==========================================
- Hits 16711 16677 -34
- Misses 4366 4401 +35 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+209
to
+235
| // When we refactor this test suite for NUTS, reenable this | ||
| // test. test. #ifdef NNG_ENABLE_IPV6 Convey("Sending | ||
| // to an IPv6 address on IPv4 fails", { | ||
| // nng_aio *aio1; char *msg = "nope"; | ||
| // nng_sockaddr sa; int rv; | ||
| // nng_iov iov; | ||
| // | ||
| // sa.s_in6.sa_family = NNG_AF_INET6; | ||
| // // address is for google.com | ||
| // inet_ntop(AF_INET6, | ||
| // "2607:f8b0:4007:804::200e", (void *) | ||
| // sa.s_in6.sa_addr, 16); sa.s_in6.sa_port = 80; | ||
| // So(nng_aio_alloc(&aio1, NULL, NULL) == | ||
| // 0); iov.iov_buf = msg; | ||
| // iov.iov_len = strlen(msg) + 1; | ||
| // So(nng_aio_set_iov(aio1, 1, &iov) == 0); | ||
| // nng_aio_set_input(aio1, 0, &sa); | ||
| // | ||
| // nni_plat_udp_send(u1, aio1); | ||
| // nng_aio_wait(aio1); | ||
| // So((rv = nng_aio_result(aio1)) != 0); | ||
| // So(rv == NNG_EADDRINVAL || rv == | ||
| // NNG_ENOTSUP || rv == | ||
| // NNG_EUNREACHABLE || rv == NNG_EINVAL); | ||
| // nng_aio_free(aio1); | ||
| // }); | ||
| // #endif |
Check notice
Code scanning / CodeQL
Commented-out code Note test
This also checks if the build system has the definitions for AF_INET6, which might help in some embedded IPv4 only settings. The resolver test is enhanced to include a check for IPv6 enabled in the kernel. IPv6 support is enabled by default, of course.
gdamore
force-pushed
the
gdamore/noip6
branch
from
c37bb5d to
a34a07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also checks if the build system has the definitions for AF_INET6, which might help in some embedded IPv4 only settings.
The resolver test is enhanced to include a check for IPv6 enabled in the kernel.
IPv6 support is enabled by default, of course.