Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies mbedtls CMakeLists.txt #1772

Closed
wants to merge 2 commits into from
Closed

Conversation

shikokuchuo
Copy link
Contributor

Fixes #1771 The new findMbedTLS from NNG 1.7.2 fails

The first commit simplifies the logic such that is works again (as described in the issue).
The second commit just tidies up the new BSD socket transport documentation.

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

@gdamore
Copy link
Contributor

gdamore commented Feb 14, 2024

I see one typo in the original code. I am not sure that I want to take this entire change. It may be best just to fix the typo.

@shikokuchuo
Copy link
Contributor Author

Correcting the typo didn't change anything when I tested. I've updated the issue - something is still not quite right it seems.

@gdamore
Copy link
Contributor

gdamore commented Feb 18, 2024

This change is wrong. And I've tested this reasonably myself with a variety of settings. I think something else is wrong in your environment. I'm closing this PR for now, because I'm not going to accept it as is. I think more investigation of the problem is required first.

@gdamore gdamore closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new findMbedTLS from NNG 1.7.2 fails
2 participants