Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages): include street_address field in schemas, dtos and st… #504

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

afkzoro
Copy link
Contributor

@afkzoro afkzoro commented Oct 30, 2024

…icky

What kind of PR is this?:

/kind packages

What this PR does / why we need it:

This PR improves delivery by including a street_address field in the address book.

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@github-actions github-actions bot added the kind/packages Pull requests that update @nana/sticky package label Oct 30, 2024
@siradji
Copy link
Member

siradji commented Oct 30, 2024

@afkzoro is there a create address DTO? If yes please update it to

@afkzoro
Copy link
Contributor Author

afkzoro commented Oct 30, 2024

Done @siradji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/packages Pull requests that update @nana/sticky package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants