fix: endpoints returning status code 500 #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siradji
requested changes
Oct 25, 2024
| @@ -124,7 +124,7 @@ export class OrdersController { | |||
| streamUpdates: true | |||
| } | |||
| return await lastValueFrom<ResponseWithStatus>( | |||
| this.ordersClient.send(QUEUE_MESSAGE.UPDATE_ORDER_STATUS, payload).pipe( | |||
| this.ordersClient.emit(QUEUE_MESSAGE.UPDATE_ORDER_STATUS, payload).pipe( | |||
There was a problem hiding this comment.
Incorrect. Send is the correct method. refer to line 69 in order-service.controller.ts
There was a problem hiding this comment.
Even so but that doesnt solve the underlying issue. Check if anything is getting returned
There was a problem hiding this comment.
Wrap the code in the circle in an observable. lastValueFrom
There was a problem hiding this comment.
Please learn to look at for root cause when debugging. If something doesnt make sense and it works, there is something definitely wrong
There was a problem hiding this comment.
The request body still reaches the orders controller if send or emit is used. The error is only thrown from the admin gateway.
Tested with and without the
lastValueFromobservable
siradji
requested changes
Oct 30, 2024
| @@ -123,6 +123,7 @@ export class OrdersController { | |||
| ...data, | |||
| streamUpdates: true | |||
| } | |||
| console.log(payload) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Fixes a couple of endpoints in the admin gateway, returning status code 500.
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?:
Developer Checklist: