Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringSliceVar for repeated vars. #1368

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Use StringSliceVar for repeated vars. #1368

merged 1 commit into from
Jan 7, 2025
+17 −11

Conversation

n-g
Copy link
Contributor

@n-g n-g commented Jan 7, 2025

This supports comma separation, and repeated flags.

@n-g
Use StringSliceVar for repeated vars.
06f1fb6 
This supports comma separation, and repeated flags.
@n-g n-g requested a review from edganiukov January 7, 2025 13:35
@n-g n-g enabled auto-merge January 7, 2025 13:35
@n-g n-g mentioned this pull request Jan 7, 2025
Merged
edganiukov
edganiukov approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@edganiukov edganiukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@n-g n-g added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit a77e0c5 Jan 7, 2025
18 checks passed
@n-g n-g deleted the niklas-string-slice branch January 7, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edganiukov edganiukov edganiukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-g @edganiukov