Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md edits #52

Open
wants to merge 2 commits into
base: internal
Choose a base branch
from
Open

README.md edits #52

wants to merge 2 commits into from

Conversation

lasersPew
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lasersPew lasersPew mentioned this pull request Oct 12, 2021
Open
@namanshergill
Copy link
Owner

How come GitHub thinks EVERY file in the project is being changed in this PR🤔

@namanshergill
Copy link
Owner

Can you use the cherry pick command to only include the readme changes? I can also manually move them over if you would like, with the changes I mentioned in the comments above, would you prefer that?

@lasersPew
Copy link
Author

I just changed the readme. Te things I omitted is included btw in #51

@namanshergill
Copy link
Owner

I just changed the readme. Te things I omitted is included btw in #51

Yep I went through it! I mostly mentioned the cherry pick command because GitHub thinks every file is being changed, so you can only cherry pick the Readme, or I can manually move the changes over with my comments I mentioned above if you would prefer that?

@lasersPew
Copy link
Author

Well, you can manually move the changes since i couldn't cherrypick the readme.

@namanshergill
Copy link
Owner

Oh whoops, this completely slipped my mind, sorry! Gonna work on adding the wiki asap now that I'm able to work on the project again.

@HikaruIchijyo
Copy link

Oh whoops, this completely slipped my mind, sorry! Gonna work on adding the wiki asap now that I'm able to work on the project again.

Yay finally

@lasersPew lasersPew closed this May 21, 2023
@lasersPew lasersPew reopened this May 21, 2023
@lasersPew
Copy link
Author

Reopened this PR as I added more changes to the README

  • Brought back the features
  • Changed Logo Link
  • Retractable Screenshots
  • Added Buy me a Coffee image

@namanshergill
Copy link
Owner

Hey! Thanks for fixing the issue with all files being marked as changed (that would have messed git blame and would have made it hard to track where exactly a specific part of code was changed in the past).

There are a couple of changes I would like to mention (for example, files under assets are compiled with the app, so might need to move the coffee icon), but I’m currently on vacation so will share them in the next weekend.

Thanks for the PR, the repo did need a better organised readme

@lasersPew
Changed README
24e4299 
Added Logo link
Added Buy me a Coffee link
Added link to wiki
Added Retractable Screenshots
@lasersPew
Copy link
Author

There are a couple of changes I would like to mention (for example, files under assets are compiled with the app, so might need to move the coffee icon), but I’m currently on vacation so will share them in the next weekend.

Would placing it onto ./repoassets do the trick?

@lasersPew lasersPew changed the title Edited README.md and added som QoL updates to the repository README.md edits Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lasersPew @CLAassistant @namanshergill @HikaruIchijyo