More emphasis on extreme values #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values will never actually wrap with the current set of limits. It's better if we get notified if the calculations wrap in debug builds.
Benchmark for 6dcaa83Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to make it easier to prove that the algorithms are correct for the entire value range by adding tests in all the algorithms for the extreme values, and also quickcheck the entire range instead of just what is supported by the time library.
In addition to that, with the current RD_MIN and RD_MAX, the wrapping operations were not actually needed. So decided to remove all of them (except
wrapping_mulin the one algorithm that actually depends on it). Now if we get a wrap, in debug builds we should get a panic, which is correct for these algorithms.