New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use `i8` instead of `u8` for all types #50

Draft

nakedible wants to merge 3 commits into master from i8

Owner

nakedible commented Aug 6, 2024

No description provided.

nakedible added 2 commits

August 6, 2024 21:20


          feat: Use i8 instead of u8 for all types

baefff4


          chore: Fix tests and benchmarks for i8

22e0dab

nakedible changed the title I8 Use i8 instead of u8 for all types


          chore: Update asm after i8 change

6cc8e31

Contributor

github-actions bot commented Aug 6, 2024

Benchmark for `c6f6a62`

Click to view benchmark

Test	Base	PR	%
date_to_isoweekdate	10.3±0.36ns	10.7±0.15ns	+3.88%
date_to_rd	2.5±0.04ns	2.7±0.08ns	+8.00%
date_to_weekday	2.7±0.04ns	2.9±0.07ns	+7.41%
datetime_to_secs	5.3±0.08ns	6.9±0.12ns	+30.19%
datetime_to_systemtime	9.9±0.10ns	10.2±0.15ns	+3.03%
days_in_month	1.4±0.09ns	1.3±0.10ns	-7.14%
dhms_to_secs	1.9±0.04ns	1.9±0.04ns	0.00%
is_leap_year	1.3±0.07ns	1.2±0.08ns	-7.69%
isoweekdate_to_date	7.4±0.32ns	7.8±0.16ns	+5.41%
isoweekdate_to_rd	2.8±0.07ns	2.6±0.06ns	-7.14%
isoweeks_in_year	1.9±0.04ns	1.9±0.03ns	0.00%
next_date	1.2±0.14ns	1.2±0.05ns	0.00%
overhead	0.7±0.02ns	0.7±0.02ns	0.00%
prev_date	1.5±0.03ns	1.5±0.08ns	0.00%
rd_to_date	4.0±0.20ns	4.0±0.24ns	0.00%
rd_to_isoweekdate	6.2±0.11ns	6.2±0.18ns	0.00%
rd_to_weekday	0.8±0.05ns	0.8±0.05ns	0.00%
secs_to_datetime	7.3±0.31ns	7.3±0.36ns	0.00%
secs_to_dhms	3.1±0.06ns	3.1±0.18ns	0.00%
secs_to_systemtime	4.1±0.41ns	3.6±0.24ns	-12.20%
systemtime_to_datetime	32.7±0.51ns	32.7±2.74ns	0.00%
systemtime_to_secs	18.0±1.44ns	17.9±0.14ns	-0.56%

Contributor

github-actions bot commented Aug 6, 2024

Benchmark for `b5673bc`

Click to view benchmark

Test	Base	PR	%
date_to_isoweekdate	10.3±0.12ns	10.7±0.12ns	+3.88%
date_to_rd	2.5±0.07ns	2.7±0.07ns	+8.00%
date_to_weekday	2.7±0.05ns	2.9±0.05ns	+7.41%
datetime_to_secs	5.3±0.08ns	6.9±0.09ns	+30.19%
datetime_to_systemtime	10.0±0.13ns	10.2±0.17ns	+2.00%
days_in_month	1.4±0.05ns	1.3±0.04ns	-7.14%
dhms_to_secs	1.9±0.04ns	1.9±0.06ns	0.00%
is_leap_year	1.3±0.03ns	1.2±0.05ns	-7.69%
isoweekdate_to_date	7.4±0.09ns	7.7±0.10ns	+4.05%
isoweekdate_to_rd	2.8±0.06ns	2.6±0.06ns	-7.14%
isoweeks_in_year	1.9±0.11ns	1.9±0.09ns	0.00%
next_date	1.2±0.03ns	1.2±0.03ns	0.00%
overhead	0.7±0.01ns	0.7±0.01ns	0.00%
prev_date	1.5±0.04ns	1.5±0.05ns	0.00%
rd_to_date	4.0±0.06ns	4.0±0.13ns	0.00%
rd_to_isoweekdate	6.2±0.20ns	6.2±0.13ns	0.00%
rd_to_weekday	0.8±0.02ns	0.8±0.03ns	0.00%
secs_to_datetime	7.3±0.24ns	7.3±0.19ns	0.00%
secs_to_dhms	3.1±0.05ns	3.1±0.04ns	0.00%
secs_to_systemtime	3.7±0.15ns	4.0±0.14ns	+8.11%
systemtime_to_datetime	31.5±0.86ns	32.5±0.17ns	+3.17%
systemtime_to_secs	18.7±0.17ns	17.9±0.15ns	-4.28%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet