Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL min_version/max_version support #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrpasquini
Copy link

@mrpasquini mrpasquini commented Jul 17, 2020

Addressing issue: #390

Add support for passing min_version and max_version to openSSL context. ssl_version is deprecated in favor of these new attributes: https://ruby-doc.org/stdlib-2.5.1/libdoc/openssl/rdoc/OpenSSL/SSL/SSLContext.html#method-i-ssl_version-3D

Raise a NotImplementedError error for jruby if min_version or max_version are set.

@mrpasquini mrpasquini force-pushed the support_ssl_context_config_min_max_version branch from 7fca465 to c74299f Compare July 17, 2020 18:24
@mrpasquini
Copy link
Author

Project does not seem active, closing this PR

@mrpasquini mrpasquini closed this Nov 5, 2020
@mrpasquini mrpasquini reopened this Nov 22, 2020
@mrpasquini mrpasquini force-pushed the support_ssl_context_config_min_max_version branch from c74299f to 001b93a Compare November 22, 2020 21:36
@mrpasquini mrpasquini force-pushed the support_ssl_context_config_min_max_version branch from 001b93a to 0f04a6a Compare November 23, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant