Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More CI #58

Merged
merged 12 commits into from
Oct 24, 2023
Merged

More CI #58

merged 12 commits into from
Oct 24, 2023

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Oct 24, 2023 •
edited
Loading

  • Rust Tests
  • cargo clippy
  • cargo fmt
  • cargo doc
  • python test
  • go test

@dignifiedquire dignifiedquire marked this pull request as ready for review October 24, 2023 21:03
Arqu
Arqu reviewed Oct 24, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Arqu
Arqu reviewed Oct 24, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
ramfox
ramfox approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! filed the flakey rust test issues here: #59

@dignifiedquire dignifiedquire merged commit b090eb6 into main Oct 24, 2023
11 of 12 checks passed
@dignifiedquire dignifiedquire deleted the more-ci branch October 24, 2023 22:19
@ramfox ramfox mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arqu Arqu Arqu left review comments

@ramfox ramfox ramfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dignifiedquire @Arqu @ramfox