Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original 'set number' if filetype in exclusion list #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Armour
Copy link

@Armour Armour commented May 25, 2015

When I added 'set number' and excluded nerdtree, tagbar and taglist, I found that my nerdtree have no line number on default because of the exclusion.
So here I add some codes to preserve 'set number' effects when filetype is in exclusion list.
Already tested :D

PS: Also found another bug that if the nerdtree or tagbar has been set to 'autofocus' then the first time it appears the line number will not works as we expected, I'm trying to fix it now.

@myusuf3
Copy link
Owner

myusuf3 commented May 25, 2015

@Armour if you fix that can you open another PR.

Thanks. Can you send me screenshots of this PR working. Video would be great too if its not too much trouble.

@Armour
Copy link
Author

Armour commented May 26, 2015

Okey
before check
This is the screenshot before fix, you can see that I added 'set number' but the line numbers in nerdtree still disappeared due to the exclusion. This is not what I want...

after check
After fix it, we now can keep the line numbers showing here if we add 'set number'.

Btw, if no 'set number', all works well like before.

@ytian81
Copy link

ytian81 commented Mar 9, 2019

Any plan to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants