Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #42 #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes issue #42 #44

wants to merge 1 commit into from

Conversation

gguimaraesbr
Copy link

No description provided.

@fatbird
Copy link

fatbird commented Aug 27, 2013

Confirm that this fixes the issue in my environment

@merenbach
Copy link

Chiming in to confirm as well that that this solves the issue in my environment.

@myusuf3
Copy link
Owner

myusuf3 commented Oct 4, 2013

I know I have been taking my time, but I need to confirm it works for everyone. so if you guys could paste in your vim versions that would be great! 💯

@merenbach
Copy link

@myusuf3 this fixes two versions for me.

Without GUI:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct  3 2013 11:03:24)                                                                                                                                                                                                                              
MacOS X (unix) version
Included patches: 1-27
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +cindent         +conceal         +digraphs        +farsi           -gettext         +libcall         +mksession       +mouse_netterm   -mzscheme        +profile         +scrollbind      +syntax          +textobjects     +visualextra     -X11
+arabic          -clientserver    +cryptv          -dnd             +file_in_path    -hangul_input    +linebreak       +modify_fname    +mouse_sgr       +netbeans_intg   +python          +signs           +tag_binary      +title           +viminfo         -xfontset
+autocmd         +clipboard       +cscope          -ebcdic          +find_in_path    +iconv           +lispindent      +mouse           -mouse_sysmouse  +path_extra      -python3         +smartindent     +tag_old_static  -toolbar         +vreplace        -xim
-balloon_eval    +cmdline_compl   +cursorbind      +emacs_tags      +float           +insert_expand   +listcmds        -mouseshape      +mouse_urxvt     -perl            +quickfix        -sniff           -tag_any_white   +user_commands   +wildignore      -xsmp
-browse          +cmdline_hist    +cursorshape     +eval            +folding         +jumplist        +localmap        +mouse_dec       +mouse_xterm     +persistent_undo +reltime         +startuptime     -tcl             +vertsplit       +wildmenu        -xterm_clipboard
++builtin_terms  +cmdline_info    +dialog_con      +ex_extra        -footer          +keymap          -lua             -mouse_gpm       +multi_byte      +postscript      +rightleft       +statusline      +terminfo        +virtualedit     +windows         -xterm_save
+byte_offset     +comments        +diff            +extra_search    +fork()          +langmap         +menu            -mouse_jsbterm   +multi_lang      +printer         +ruby            -sun_workshop    +termresponse    +visual          +writebackup     -xpm
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: /usr/bin/clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX -no-cpp-precomp  -Os -w -pipe -march=native -Qunused-arguments -mmacosx-version-min=10.8 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: /usr/bin/clang   -L.    -L/usr/local/lib -Wl,-headerpad_max_install_names -o vim        -lm  -lncurses -liconv -framework Cocoa    -framework Python   -lruby -lobjc

With GUI:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct  3 2013 10:29:01)
MacOS X (unix) version
Included patches: 1-22
Compiled by Homebrew
Huge version with MacVim GUI.  Features included (+) or not (-):
+acl             +clientserver    +cscope          +emacs_tags      +folding         +jumplist        -lua             -mouse_jsbterm   -mzscheme        +profile         +signs           +tag_old_static  +transparency    +wildignore      -xterm_clipboard
+arabic          +clipboard       +cursorbind      +eval            -footer          +keymap          +menu            +mouse_netterm   +netbeans_intg   +python          +smartindent     -tag_any_white   +user_commands   +wildmenu        -xterm_save
+autocmd         +cmdline_compl   +cursorshape     +ex_extra        +fork()          +langmap         +mksession       +mouse_sgr       +odbeditor       -python3         -sniff           +tcl             +vertsplit       +windows         -xpm
+balloon_eval    +cmdline_hist    +dialog_con_gui  +extra_search    +fullscreen      +libcall         +modify_fname    -mouse_sysmouse  +path_extra      +quickfix        +startuptime     +terminfo        +virtualedit     +writebackup
+browse          +cmdline_info    +diff            +farsi           -gettext         +linebreak       +mouse           +mouse_urxvt     +perl            +reltime         +statusline      +termresponse    +visual          -X11
++builtin_terms  +comments        +digraphs        +file_in_path    -hangul_input    +lispindent      +mouseshape      +mouse_xterm     +persistent_undo +rightleft       -sun_workshop    +textobjects     +visualextra     -xfontset
+byte_offset     +conceal         +dnd             +find_in_path    +iconv           +listcmds        +mouse_dec       +multi_byte      +postscript      +ruby            +syntax          +title           +viminfo         +xim
+cindent         +cryptv          -ebcdic          +float           +insert_expand   +localmap        -mouse_gpm       +multi_lang      +printer         +scrollbind      +tag_binary      +toolbar         +vreplace        -xsmp
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation:
cc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX -no-cpp-precomp  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1     -I/System/Library/Frameworks/Tcl.framework/Headers  -D_REENTRANT=1  -D_THREAD_SAFE=1  -D_DARWIN_C_SOURCE=1
Linking: cc   -L.   -L.    -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lncurses -liconv -framework Cocoa   -fstack-protector -L/usr/local/lib  -L/System/Library/Perl/5.12/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc -framework Python  -F/System/Library/Fra
meworks -framework Tcl -framework CoreFoundation -framework Ruby

Thank you!

@myusuf3
Copy link
Owner

myusuf3 commented Oct 4, 2013

@merenbach

kk perfect I will test 7.3 and if we are good I will merge this.

@gguimaraesbr
Copy link
Author

Noticed that when switching off and on, the current line number changes from X to 0. Is it the expected behavior?

@myusuf3
Copy link
Owner

myusuf3 commented Oct 16, 2013

That is vim's expected behaviour for newer versions of vim the link you are on is zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants