Clang-tidy (clang-12, tiles)

Goo canister will correctly consume charges on use (#3138) #27

Sign in to view logs

Annotations

10 warnings

src/mapgen.cpp#L86

Variable 'GROUP_NETHER' declared but not used. [cata-unused-statics]

src/mapgen.cpp#L88

Variable 'GROUP_ROBOT_SECUBOT' declared but not used. [cata-unused-statics]

src/ranged.cpp#L129

Variable 'skill_dodge' declared but not used. [cata-unused-statics]

src/ranged.cpp#L873

'ammo' used after it was moved [bugprone-use-after-move]

tests/find_auto_consume_test.cpp#L97

Prefer constructing 'tripoint' from named constant 'tripoint_east' rather than explicit integer arguments. [cata-use-named-point-constants]

tests/find_auto_consume_test.cpp#L140

Prefer constructing 'tripoint' from named constant 'tripoint_east' rather than explicit integer arguments. [cata-use-named-point-constants]

src/explosion.cpp#L552

Variable 'delay_ms' declared as 'const long'. Prefer int or int64_t to long. [cata-no-long]

src/explosion.cpp#L552

Static cast to 'long'. Prefer int or int64_t to long. [cata-no-long]

src/bionics.cpp#L499

return type 'const std::map<item, bionic_id>' (aka 'const map<item, string_id<bionic_data>>') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type]

src/npc.h#L1425

function 'npc_overmap::spawn_chance_in_hour' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

The logs for this run have expired and are no longer available.