-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release IP address on session stop #5970
Conversation
@@ -188,6 +188,7 @@ func (m *Manager) ProvideConfig(sessionID string, sessionConfig json.RawMessage, | |||
if err := conn.Stop(); err != nil { | |||
log.Error().Err(err).Msg("Failed to stop connection endpoint") | |||
} | |||
conn.ReleaseIP(config.Consumer.IPAddress) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same are done in the next line, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
0621c05
to
cbdc9dd
Compare
cbdc9dd
to
3335b1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5970 +/- ##
==========================================
+ Coverage 37.90% 37.97% +0.06%
==========================================
Files 371 371
Lines 20665 20715 +50
==========================================
+ Hits 7833 7866 +33
- Misses 12054 12064 +10
- Partials 778 785 +7 ☔ View full report in Codecov by Sentry. |
3335b1b
to
97a83b0
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had activity for a long time. If this pull request is still valid, please ping a maintainer and ask them to label it as "pinned". Thank you for your contributions. |
Signed-off-by: Anton Litvinov <[email protected]>
4dc87cb
to
d164333
Compare
Signed-off-by: Anton Litvinov <[email protected]>
8f6c170
to
be5e15b
Compare
Signed-off-by: Anton Litvinov <[email protected]>
Symptoms:
Cause:
IP is allocated for consumer on session start, but never gets released. Given the limited size of IP pool, exhaustion can happen in a few days or hours.