Remove v3 pricer #104
Merged
Remove v3 pricer #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pricer API version 3 removal
All the functions and modules were already present in the new
price/pricingbyservice, therefore, v3 removal required only references updates (price/pricing->price/pricingbyservice) and a couple of consts/vars copied to a new location.One small logic update happened inValidatefunction - before it did not allow prices to be equal to 0, which is not aligns with its claimprices should be zero or non negative.detects unset pricinge2e test case was removed because it is not relevant to price struct without references - "unset" objects will have 0 values anyway.UPDATE: Price validation function clarified - values must be higher than 0. The test is restored.