[ExcelAnalyzer] refactor metadata rendering

mysociety · May 24, 2024 · b64239d · b64239d
1 parent 06a0e93
commit b64239d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/views/excel_analyzer/notifier_mailer/report.text.erb b/lib/views/excel_analyzer/notifier_mailer/report.text.erb
@@ -4,9 +4,6 @@ spreadsheet due to the detection of potentially suspect hidden data.
 Admin request URL: <%= admin_request_url(@incoming_message.info_request_id) %>
 Admin attachment URL: <%= edit_admin_foi_attachment_url(@foi_attachment) %>
 
-The following was detected:
-<% @metadata[:excel].each do |key, value| %>
-  <%= key %>: <%= value %>
-<% end %>
+Excel Analyzer metadata: <%= JSON.pretty_generate(@metadata[:excel]) %>
 
 Please review the file carefully.
diff --git a/spec/excel_analyzer/mailers/notifier_mailer_spec.rb b/spec/excel_analyzer/mailers/notifier_mailer_spec.rb
@@ -47,6 +47,6 @@
 
   it 'includes the metadata in the body' do
     allow(blob).to receive(:metadata).and_return(excel: { foo: 'bar' })
-    expect(mail.body).to include('foo: bar')
+    expect(mail.body).to include('"foo": "bar"')
   end
 end