-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Waste] Factor out garden costs to single package. #5324
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bexley-ww-pre-work-refactor #5324 +/- ##
===============================================================
+ Coverage 82.43% 82.47% +0.03%
===============================================================
Files 416 417 +1
Lines 32904 32939 +35
Branches 5278 5282 +4
===============================================================
+ Hits 27125 27166 +41
+ Misses 4221 4217 -4
+ Partials 1558 1556 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a couple of incidental comments that are just very minor queries of style, but this seems to work according to the tests. As you say, direct tests on the new package would help confirm its reliability.
96aa17f
to
fbbb05a
Compare
d6cf430
to
3698b3d
Compare
3698b3d
to
63b570e
Compare
Moved service inside Costs.pm; then made some small additional changes - moved _get_costs into the Costs.pm as well, small wording changes, put all the cobrand bits together. Then noticed end date could be taken from the service as well mostly, so moved that out of some calls. And added a tests file. Probably worth a re-review, check my tests look as you'd expect :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this looks good to me.
Moves all garden costs/discount stuff to its own package which can then be queried for costs.
And adds a 'different price for first bin'
[skip changelog]