Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aberdeenshire] Added cobrand front-end #5323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Jan 13, 2025

Fixes: https://github.com/mysociety/societyworks/issues/4611

For Aberdeenshire.pm I just made names changes so I can style the cobrand.

Preview:

Desktop:

Screenshot 2025-01-13 at 08 36 54 Screenshot 2025-01-13 at 08 37 29 Screenshot 2025-01-13 at 08 37 49

Mobile

Screenshot 2025-01-13 at 08 38 44 Screenshot 2025-01-13 at 08 38 56 Screenshot 2025-01-13 at 08 39 18

Emails

Screenshot 2025-01-13 at 08 39 58 Screenshot 2025-01-13 at 08 40 16

[Skin changelog]

@lucascumsille lucascumsille requested a review from davea January 13, 2025 08:42
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 16.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (cdd00e2) to head (c9f98aa).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Aberdeenshire.pm 16.00% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5323      +/-   ##
==========================================
- Coverage   82.44%   82.31%   -0.14%     
==========================================
  Files         415      416       +1     
  Lines       32903    32977      +74     
  Branches     5277     5288      +11     
==========================================
+ Hits        27128    27146      +18     
- Misses       4218     4271      +53     
- Partials     1557     1560       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant