Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Waste] Ignore any other bodies returned. #5321

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Jan 6, 2025

The Merton body covers Kingston’s area due to an out-of-area park which is Merton’s responsibility. We do not care about this for waste. Fallout from parks deploy; this caused the cron emails from send-waste this morning as the Merton-only script picked up a Kingston report assigned to both. [skip changelog]

The Merton body covers Kingston’s area due to an out-of-area park which
is Merton’s responsibility. We do not care about this for waste.
@dracos dracos requested a review from MorayMySoc January 6, 2025 12:35
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (64a5ad8) to head (583a4f6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5321   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         415      415           
  Lines       32896    32900    +4     
  Branches     5275     5276    +1     
=======================================
+ Hits        27117    27122    +5     
+ Misses       4220     4219    -1     
  Partials     1559     1559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos force-pushed the fixed-bodies_str-waste branch from 23ad783 to 583a4f6 Compare January 6, 2025 12:55
Copy link
Contributor

@MorayMySoc MorayMySoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me

@dracos dracos merged commit 583a4f6 into master Jan 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants