[Echo] Add address_types to the Echo integration class #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 415 415
Lines 32904 32903 -1
Branches 5277 5277
=======================================
Hits 27128 27128
+ Misses 4219 4218 -1
Partials 1557 1557 ☔ View full report in Codecov by Sentry. |
davea
approved these changes
Jan 6, 2025
This simplifies the code by avoiding the need to pass the config around, and also means that calling FindPoints via call-wasteworks-backend will only return address_types from the config file without the need to manually pass in the config.
mysociety-pusher
force-pushed
the
echo-findpoints-use-config-properly
branch
from
71d1ac5 to
cdd00e2
Compare
mysociety-pusher
temporarily deployed
to
github-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code by avoiding the need to pass the config around.
It also means that calling FindPoints via
call-wasteworks-backendwill only return address_types from the config file without the need to manually pass in the config.Came up while investigating FD-4972