Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gloucester] Added cobrand front-end #5295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Dec 10, 2024

Fixes: https://github.com/mysociety/societyworks/issues/4610

It includes:

  • Logos
  • Fonts
  • Emails
  • Colours
  • Navigation bar
  • favicon
  • Site message

Desktop

Screen.Recording.2024-12-10.at.10.40.57.mov
Screen.Recording.2024-12-10.at.10.41.28.mov
Screen.Recording.2024-12-10.at.10.41.55.mov

Mobile

Screen.Recording.2024-12-10.at.10.47.12.mov

Emails

Screenshot 2024-12-10 at 10 42 38 Screenshot 2024-12-10 at 10 43 10

[skip changelog]

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.37%. Comparing base (90b926b) to head (d1f60dd).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Gloucester.pm 19.04% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5295      +/-   ##
==========================================
- Coverage   82.41%   82.37%   -0.05%     
==========================================
  Files         415      416       +1     
  Lines       32851    32872      +21     
  Branches     5270     5271       +1     
==========================================
+ Hits        27074    27078       +4     
- Misses       4219     4236      +17     
  Partials     1558     1558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucascumsille
Copy link
Contributor Author

Hi @chrismytton just in case I deleted most of the files that are not yet necessary, but I didn't delete the following:

  • assets,js
  • tracking_code.html
  • footer_extra_js.html

Those ones have the same info as Gloucestershire

@chrismytton
Copy link
Member

@lucascumsille Thanks! Will have a proper look at this next week and get it onto staging 🙂

@chrismytton chrismytton force-pushed the gloucester-front-end branch 4 times, most recently from 52a6ff2 to 8b2c00d Compare December 18, 2024 16:42
It includes

- Logos
- Fonts
- Emails
- Colours
- Navigation bar
- favicon
- Site message
@chrismytton
Copy link
Member

I've deployed this to staging so now waiting to see if the client has any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants