Daemon locking improvements #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4735 +/- ##
===========================================
- Coverage 85.26% 27.68% -57.59%
===========================================
Files 340 335 -5
Lines 24428 24157 -271
Branches 4631 4585 -46
===========================================
- Hits 20829 6688 -14141
- Misses 2189 16766 +14577
+ Partials 1410 703 -707 ☔ View full report in Codecov by Sentry. |
davea
requested changes
Nov 24, 2023
Add a processing state so the daemons still do not clash, but unlock the row during actual processing in case that takes a long time. Changes to prevent race conditions in processing coming up next.
Introduce a new open311_update_missing_data cobrand hook to be used to add/save any missing data to the report before sending via Open311, that is wrapped in a transaction. open311_extra_data_include should now only be used to add columns for sending, not to edit the row in any way. When sending via Open311, any changes made pre-send (after update_missing_data) are now automatically discarded after sending.
dracos
force-pushed
the
daemon-improve-locking
branch
from
bfd6b2b to
d977312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]