Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brent] Small items other electrical note #4657

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

dracos
Copy link
Member

@dracos dracos commented Oct 9, 2023

Uses most of code from K&S notes commit (might be a bit of work done to merge both as have rejigged slightly)
For https://3.basecamp.com/4020879/buckets/33769634/todos/6624115227
[skip changelog]

@dracos dracos requested a review from MorayMySoc October 9, 2023 13:30
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4657 (305f8b8) into brent-initial-setup (a339eaf) will not change coverage.
Report is 9 commits behind head on brent-initial-setup.
The diff coverage is n/a.

❗ Current head 305f8b8 differs from pull request most recent head ab825c8. Consider uploading reports for the commit ab825c8 to get more accurate results

@@                 Coverage Diff                  @@
##           brent-initial-setup    #4657   +/-   ##
====================================================
  Coverage                69.23%   69.23%           
====================================================
  Files                       42       42           
  Lines                     4951     4951           
====================================================
  Hits                      3428     3428           
  Misses                    1523     1523           

Copy link
Contributor

@MorayMySoc MorayMySoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small points, but think the important stuff works

web/js/waste.js Outdated Show resolved Hide resolved
@dracos dracos force-pushed the brent-initial-setup branch from aaa87d9 to ede5690 Compare October 10, 2023 09:01
@dracos dracos force-pushed the brent-small-item-other branch from e1adcac to ab825c8 Compare October 10, 2023 09:04
@dracos dracos merged commit ab825c8 into brent-initial-setup Oct 10, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants