Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLWP] Kands collection page changes #4655

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Oct 9, 2023

Adds js for updating the amount of selected items and if price change is imminent.

Changes text for introduction box.

Fixes bug where total not being updated on page load.

Fixes final part of https://github.com/mysociety/societyworks/issues/3937
[skip changelog]

@MorayMySoc MorayMySoc requested a review from dracos October 9, 2023 11:46
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4655 (9ace689) into kands-bulky-setup (3093845) will decrease coverage by 13.38%.
The diff coverage is n/a.

❗ Current head 9ace689 differs from pull request most recent head d6a75b6. Consider uploading reports for the commit d6a75b6 to get more accurate results

@@                  Coverage Diff                   @@
##           kands-bulky-setup    #4655       +/-   ##
======================================================
- Coverage              82.59%   69.21%   -13.38%     
======================================================
  Files                    378       42      -336     
  Lines                  28855     4951    -23904     
  Branches                4506        0     -4506     
======================================================
- Hits                   23832     3427    -20405     
+ Misses                  3678     1524     -2154     
+ Partials                1345        0     -1345     

see 336 files with indirect coverage changes

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting using the same source of data in the JS, and bit of JS simplifying maybe :)

templates/web/base/waste/bulky/items.html Outdated Show resolved Hide resolved
templates/web/base/waste/bulky/items.html Outdated Show resolved Hide resolved
web/js/waste.js Show resolved Hide resolved
web/js/waste.js Outdated Show resolved Hide resolved
web/js/waste.js Outdated Show resolved Hide resolved
@dracos dracos force-pushed the kands-collection-page-changes branch from d4348f4 to ca639d5 Compare October 10, 2023 13:00
@dracos dracos force-pushed the kands-collection-page-changes branch from ca639d5 to d6a75b6 Compare October 10, 2023 13:02
@dracos dracos merged commit d6a75b6 into kands-bulky-setup Oct 10, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants