-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLWP] Kands collection page changes #4655
Conversation
Codecov Report
@@ Coverage Diff @@
## kands-bulky-setup #4655 +/- ##
======================================================
- Coverage 82.59% 69.21% -13.38%
======================================================
Files 378 42 -336
Lines 28855 4951 -23904
Branches 4506 0 -4506
======================================================
- Hits 23832 3427 -20405
+ Misses 3678 1524 -2154
+ Partials 1345 0 -1345 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting using the same source of data in the JS, and bit of JS simplifying maybe :)
d4348f4
to
ca639d5
Compare
Adds updating the total cost when the page is reloaded
Keeps running total of items selected and warns of cost change https://3.basecamp.com/4020879/buckets/33314444/todos/6618280655
ca639d5
to
d6a75b6
Compare
Adds js for updating the amount of selected items and if price change is imminent.
Changes text for introduction box.
Fixes bug where total not being updated on page load.
Fixes final part of https://github.com/mysociety/societyworks/issues/3937
[skip changelog]