Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackney] Add favicon #4654

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[Hackney] Add favicon #4654

merged 1 commit into from
Oct 9, 2023

Conversation

chrismytton
Copy link
Member

Add favicon for the Hackney cobrand.

For https://mysocietysupport.freshdesk.com/a/tickets/2970

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4654 (cb7b80e) into master (b0684a4) will decrease coverage by 13.01%.
The diff coverage is n/a.

❗ Current head cb7b80e differs from pull request most recent head 686bcef. Consider uploading reports for the commit 686bcef to get more accurate results

@@             Coverage Diff             @@
##           master    #4654       +/-   ##
===========================================
- Coverage   82.22%   69.21%   -13.01%     
===========================================
  Files         378       42      -336     
  Lines       28729     4951    -23778     
  Branches     4491        0     -4491     
===========================================
- Hits        23623     3427    -20196     
+ Misses       3758     1524     -2234     
+ Partials     1348        0     -1348     

see 338 files with indirect coverage changes

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If instead of this you put https://hackney.gov.uk/icons-a94e822ed66a743ac1649752651b4d73/favicon.ico at web/cobrands/hackney/favicon.ico then that has more sizes as far as I can see and no need to change a template.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@mysociety-pusher mysociety-pusher merged commit 686bcef into master Oct 9, 2023
18 of 19 checks passed
@mysociety-pusher mysociety-pusher temporarily deployed to github-pages October 9, 2023 10:09 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants