Multi year staging #149
Merged
Multi year staging #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables multiple sets of questions etc to be in one database by associating sections and assignments with a marking session
Set this as a propery on the request object which is not entirely ideal but is handy. Also set some context data with current session and all sessions as this is useful in templates
The same as the default set but with a marking session as the first element in the path so we can be specific about which marking session
Any time we load sections or assignments it needs to check the current marking session and only load the sections or assignments for that session. Also use it in counts.
Also adds a command to set up a basic session
Mostly to allow filtering using sessions, but also to display sessions
To allow different section names for different marking sessions
Enables us to refer to something other than councils in the interface
This is at a per site level.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 76.85% 78.94% +2.08%
==========================================
Files 67 80 +13
Lines 3414 3984 +570
Branches 334 357 +23
==========================================
+ Hits 2624 3145 +521
- Misses 720 767 +47
- Partials 70 72 +2 ☔ View full report in Codecov by Sentry. |
Lots of other things will probably break but at least you don't get immediately presented with a 500 error
As well as a bunch of other improvements, this brings a fix for `<button>` elements appearing unstyled when used in a `.nav` (which we do in our header).
- Admin options are now in their own navbar - Admin nav dropdown menus are end-aligned, to prevent "Stats" menu extending beyond right edge of viewport - "Sign in" nav link now leads to `login` page, rather than homepage
It seems the first one (“Volunteer progress”) is actually all about the First Mark. And there’s no need to repeat “progress” at the end of each one, especially as some of the child elements aren’t about ‘progress’ really.
There are various things that CEUK use that aren't relevant elsewhere
struan
force-pushed
the
multi-year-staging
branch
from
4c8bad5 to
552f7e5
Compare
make sure we strip and lower case, plus warn if it's not a string
makes things a bit clearer in the admin
struan
force-pushed
the
multi-year-staging
branch
from
552f7e5 to
cc57454
Compare
struan
force-pushed
the
multi-year-staging
branch
from
661ac36 to
e7b2b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all the work to cope with enabling multiple question sets to exist in grace.