Stripe Prices fixes #8472
Merged
Stripe Prices fixes #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add guard clauses - Remove brackets around conditional - Remove leading underscore on variables names
gbp
commented
Nov 27, 2024
Need to pass in the subscription param instead of ID otherwise Pro Price#retrieve method won't find the Stripe Price instance. This commit also clears up the variables in Pro Price to make it clearer what is expected and ensures prices are defined in config/general.yml.
Fixing invalid Stripe payment intent status. Should be "requires_action" this would result in payments attempts being left in an incomplete state and the user being shown the generic "try again" error message when they are signing up. See: https://docs.stripe.com/payments/paymentintents/lifecycle#intent-statuses
Change payment intents with the "requires_source_action" status from returning true. According to payment intent lifecycle this state is for when processing fails and we should display an error to the user. This change will do just that. See: https://docs.stripe.com/payments/paymentintents/lifecycle#intent-statuses
Don't send the notification when the user has no subscriptions which are past due.
Before this change, webhooks would be ignored if the main object plan/price ID didn't match the namespace. This change means we now look up the price ID against those configured in config/general.yml. Note: Since only Stripe plans are returned in the webhooks generated from the stripe-ruby-mock gem the specs still rely on setting up plans are can't be migrated to prices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds a couple of Stripe fixes for issues preventing signups.
Price.idtoPrice.to_paramso prices can be loadeds) should fix incomplete subscriptionsWhy was this needed?
Getting payments working correctly.
[skip changelog]