[#7293] Update Notable#all_notes #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethrees
reviewed
Nov 19, 2024
| @@ -4,12 +4,20 @@ | |||
| describe '#all_notes' do | |||
| subject { record.all_notes } | |||
|
|
|||
| before { record.tag_string = 'foo' } | |||
| before { record.tag_string = 'foo:1' } | |||
There was a problem hiding this comment.
might be worth making this an additional spec so that we're testing both foo and foo:1?
There was a problem hiding this comment.
Yep good shout, I have added this in a fixup.
Before this PR we had:
- PublicBody tagged with "foo:bar" would be associated with a note with tagged with "foo:bar" but not "foo"
- PublicBody tagged with "foo" would be associated with a note with tagged with "foo" but not "foo:bar"
After this PR:
- PublicBody tagged with "foo:bar" would be associated with a note with tagged with "foo:bar" or "foo"
- PublicBody tagged with "foo" would be associated with a note with tagged with "foo" but not "foo:bar"
What do you think about that last case... should a PublicBody tagged with "foo" be associated with a note with tagged with "foo:bar".
There was a problem hiding this comment.
After this PR:
- PublicBody tagged with "foo:bar" would be associated with a note with tagged with "foo:bar" or "foo"
- PublicBody tagged with "foo" would be associated with a note with tagged with "foo" but not "foo:bar"
This sounds like the correct behaviour to me.
Update the concern so that records tagged with `name:value` will be associated with notes tagged as `name`. Fixes #7293
gbp
force-pushed
the
7293-tagged-notes-without-values
branch
from
6c53468 to
8496335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7293
What does this do?
Update Notable#all_notes
Why was this needed?
Update the concern so that records tagged with
name:valuewill be associated with notes tagged asname.