Update RuboCop empty lines layout config #8014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
rubocop-empty-lines
branch
from
cb520e3 to
f3599c0
Compare
Enable all empty lines layout cops and auto correct all Ruby files. Before this change we had at least two different styles around empty lines so this ensure consistency across Ruby files. - `Layout/EmptyLineAfterGuardClause` - `Layout/EmptyLineAfterMagicComment` - `Layout/EmptyLineBetweenDefs` - `Layout/EmptyLines` - `Layout/EmptyLinesAroundAccessModifier` - `Layout/EmptyLinesAroundArguments` - `Layout/EmptyLinesAroundAttributeAccessor` - `Layout/EmptyLinesAroundBeginBody` - `Layout/EmptyLinesAroundBlockBody` - `Layout/EmptyLinesAroundClassBody` - `Layout/EmptyLinesAroundMethodBody` - `Layout/EmptyLinesAroundModuleBody` - `Layout/LeadingEmptyLines` - `Layout/TrailingEmptyLines` Ignores: - `Layout/EmptyLineAfterMultilineCondition` - `Layout/EmptyLinesAroundExceptionHandlingKeywords` Instead we use are own `EmptyLineAroundRescuedExceptions` cop.
Cop has been renamed
Ignore installed themes files.
gbp
force-pushed
the
rubocop-empty-lines
branch
from
6554f9e to
7021aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable all empty lines layout cops and auto correct all Ruby files.
Before this change we had at least two different styles around empty
lines so this ensure consistency across Ruby files.
Layout/EmptyLineAfterGuardClauseLayout/EmptyLineAfterMagicCommentLayout/EmptyLineBetweenDefsLayout/EmptyLinesLayout/EmptyLinesAroundAccessModifierLayout/EmptyLinesAroundArgumentsLayout/EmptyLinesAroundAttributeAccessorLayout/EmptyLinesAroundBeginBodyLayout/EmptyLinesAroundBlockBodyLayout/EmptyLinesAroundClassBodyLayout/EmptyLinesAroundMethodBodyLayout/EmptyLinesAroundModuleBodyLayout/LeadingEmptyLinesLayout/TrailingEmptyLinesIgnores:
Layout/EmptyLineAfterMultilineConditionLayout/EmptyLinesAroundExceptionHandlingKeywordsInstead we use are own
EmptyLineAroundRescuedExceptionscop.[skip changelog]