Only show active users on leaderboards #8012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `.group('comments.user_id')` to `.group(:user)` to match the
InfoRequest-based methods above.
This tests that the InfoRequest.is_public bit in the leaderboards methods is working as expected.
mysociety-pusher
force-pushed
the
7946-only-active-users-in-leaderboards
branch
from
d701400 to
8efc81a
Compare
mysociety-pusher
force-pushed
the
7946-only-active-users-in-leaderboards
branch
from
8efc81a to
eb2892d
Compare
garethrees
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Looks great. Good to merge as is. If it's quick and easy would be worth doing for the request game too (/categorise/play), but not worth hours of work if it's a faff.
mysociety-pusher
force-pushed
the
7946-only-active-users-in-leaderboards
branch
from
32fad1a to
4be3380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7946
What does this do?
Change the
Statistics::Leaderboardclass to only consider active users (i.e. users that haven't closed their account or been banned) from appearing on leaderboards.