Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1264] Update PublicBody#disclosure_log to be translatable #7947

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

gbp
Copy link
Member

@gbp gbp commented Oct 11, 2023

Relevant issue(s)

Fixes #1264

What does this do?

Update PublicBody#disclosure_log to be translatable

Why was this needed?

Consistency with other PublicBody attributes.

Implementation notes

Adds temp rake task to migrate existing data into the translation column which already exists in the database.

Will need a migration to remove PublicBody#disclosure_log in a future release.

gbp added a commit that referenced this pull request Oct 11, 2023
This has been replaced by translatable column in #7947.
gbp added a commit that referenced this pull request Oct 11, 2023
This has been replaced by translatable column in #7947.
@gbp gbp force-pushed the 1264-translatable-pb-disclosure-log branch from f703322 to 94b9f9c Compare October 11, 2023 14:17
Adds temp rake task to migrate existing data into the translation column
which already exists in the database.

Will need a migration to remove `PublicBody#disclosure_log` in a future
release.

Fixes #1264
@gbp gbp force-pushed the 1264-translatable-pb-disclosure-log branch from 94b9f9c to 398b23f Compare October 19, 2023 08:22
gbp added a commit that referenced this pull request Oct 19, 2023
This has been replaced by translatable column in #7947.
gbp added a commit that referenced this pull request Oct 19, 2023
This has been replaced by translatable column in #7947.
@gbp gbp merged commit 1244050 into develop Oct 19, 2023
5 checks passed
gbp added a commit that referenced this pull request Oct 25, 2023
This has been replaced by translatable column in #7947.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An authority's disclosure log url isn't translated but publication scheme url is - should they be consistent?
1 participant