Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuboCop: Layout/LineLength - Controller specs #7744

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

alexander-griffen
Copy link
Contributor

@alexander-griffen alexander-griffen commented May 15, 2023

Relevant issue(s)

#7739

What does this do?

Changes to code styling to conform to Layout/LineLength (Lines must not exceed 80 characters)

Why was this needed?

Part of making Alaveteli more consistent in styling.

Implementation notes

Some of the LineLength specs will still fail, however when the commit changing the ruby-style.yml file to exclude RSpec.describe lines is in the tree, they will not.

Screenshots

Notes to reviewer

[skip changelog]

@alexander-griffen alexander-griffen self-assigned this May 15, 2023
@alexander-griffen alexander-griffen marked this pull request as ready for review May 22, 2023 12:21
@alexander-griffen alexander-griffen requested a review from gbp May 22, 2023 12:21
@alexander-griffen alexander-griffen force-pushed the 7739-layout-line-length-spec-controllers branch from 4f93182 to 964d9c1 Compare June 23, 2023 12:52
@alexander-griffen alexander-griffen force-pushed the 7739-layout-line-length-spec-controllers branch from 964d9c1 to 0b0cc6d Compare June 23, 2023 16:11
@garethrees garethrees force-pushed the 7739-layout-line-length-spec-controllers branch from 0b0cc6d to f14cebd Compare November 16, 2023 20:00
@gbp gbp force-pushed the 7739-layout-line-length-spec-controllers branch 2 times, most recently from f021aa1 to 74637dc Compare November 20, 2023 13:08
@gbp gbp assigned gbp and unassigned alexander-griffen Nov 20, 2023
@gbp gbp force-pushed the 7739-layout-line-length-spec-controllers branch 2 times, most recently from f0c93d7 to e0fb4b2 Compare November 21, 2023 10:17
Mostly manual adjustment rather than autocorrect function due to
inconsistency in autocorrect
@gbp gbp force-pushed the 7739-layout-line-length-spec-controllers branch from e0fb4b2 to f2906ad Compare November 21, 2023 10:47
@gbp gbp merged commit e50269c into develop Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants