[#5371] Update admin timeline event filtering #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
5371-cant-change-timeframe-on-admin-timeline-when-filtering
branch
from
94ad875 to
8b7b9a8
Compare
gbp
changed the title
gbp
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
@HelenWDTK thanks for this - it was a great start. I have continued this work and refactored some more. I think this is now in a state which can be merged.
gbp
force-pushed
the
5371-cant-change-timeframe-on-admin-timeline-when-filtering
branch
from
d31e18c to
ec7e691
Compare
Allow the timeline filters by time and event types at the same time. Improves parameters by using a single `start_date` param rather than separate ones for day/hour/week/... Refactors the loading of events to use `ActiveRecord` query where possible and where isn't possible use the query builder and call `#to_sql` in order to get query sanitization.
gbp
force-pushed
the
5371-cant-change-timeframe-on-admin-timeline-when-filtering
branch
from
6a6d53a to
9b10526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #5371
What does this do?
Adds the ability to filter the timeline by time for all event types
Why was this needed?
Previously, request events and authority change events could only be displayed for the last two days unless the URL was manually manipulated, which was annoying.
Screenshots