[#6384] Add admin button to delete annotations #7670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
changed the title
gbp
force-pushed
the
6384-admin-button-to-delete-annotations
branch
from
64c10ef to
65d05f9
Compare
|
Have rebased over current develop and fixed a few linting warnings. |
garethrees
force-pushed
the
6384-admin-button-to-delete-annotations
branch
5 times, most recently
from
09f95c7 to
6bad1de
Compare
|
Squashed this down and rebased. Seems to work pretty well. |
gbp
requested changes
Jan 2, 2024
gbp
force-pushed
the
6384-admin-button-to-delete-annotations
branch
from
905bd19 to
1fec41c
Compare
If we're logging an event where an associated object has been deleted the event won't be able to created due to record being missing. This change rescues the exception when the record isn't found and assigns the record params to what would've been the global ID. This allows us visibility that there was an object associated at one point in time.
gbp
force-pushed
the
6384-admin-button-to-delete-annotations
branch
from
1fec41c to
2e0229b
Compare
|
I have refactored the event creation so that 1. we create it in the model instead of the controller 2. store the same params we did when we manually deleted comments on WDTK). Also stripped out the "delete selected" button for now to get the ability to individual comments merged sooner. |
garethrees
reviewed
Jul 23, 2024
gbp
force-pushed
the
6384-admin-button-to-delete-annotations
branch
from
322019a to
1c083f4
Compare
gbp
force-pushed
the
6384-admin-button-to-delete-annotations
branch
from
1c083f4 to
1e38524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #6384
What does this do?
Adds comment deletion to the request admin and comments admin pages, for single annotations and bulk deletion
Why was this needed?
Sometimes annotations need deleting entirely to comply with GDPR. This stops admins needing to nag the devs to do it.
Implementation notes
Screenshots
Pro Admin timeline view:
Normal admin view:
Deletion event log:
Comments admin page
Request admin page:
Single annotation edit page
Notes to reviewer
I think this is almost ready now, but there's undoubtedly room for improvement.