[#7361] Automatically tag bodies with few public requests

[garethrees]

Relevant issue(s)

Fixes #7361.

What does this do?

Automatically apply and remove a tag to requestable bodies that have a low number of public requests.

Why was this needed?

Allows users to find them via a public search to help bootstrap basic transparency/site content, and admins can add a tag-based note to suggest generally useful first requests.

Implementation notes

The number considered "not many requests" is configurable in the theme by setting PublicBody.not_many_public_requests_size.

The changelog suggests a one-shot script to mass-apply the tag to existing bodies where applicable.

It's a bit annoying that I needed to add the InfoRequest#notify_public_body hook. Can't think of a less obtrusive way of doing this though.

Screenshots

Added some admin guidance and separated out the "special" and "automatically managed" tags:

Notes to reviewer

Left the spec DRYing up as fixups just in case there's a better approach.

[gbp]

Implemented well, but wondering why we need to specify not_many_requests_tag: true on some specs now and if there is an alterative.

[garethrees]

Implemented well, but wondering why we need to specify not_many_requests_tag: true on some specs now and if there is an alterative.

Err, it's been a while… 😅 IIRC it was that in those cases the specs were intermittently failing because depending on ordering of runs an authority may or may not meet the criteria to have the tag auto-applied, and as such breaks the expectations (e.g. sometimes the tag string will be "foo", sometimes "foo not_many_requests"). Very open to a better way if you can think of one.

[gbp]

Not a fan of using RSpec example metadata to setup the specs (yeah I know I added that for features but that is different because those are optional for re-users)

I have pushed a fixup to be more explicit, adding the around example block for the 4 times the metadata was used.

[garethrees]

Okay! might see if we can refactor d9834d0 to be more like:

  describe "DELETE #mass_tag" do
    around do |example|
      disable_not_many_requests_auto_tagging { example.run }
    end

[garethrees]

Okay! might see if we can refactor d9834d0 to be more like:

Done and squashed into b12b788#diff-8799477776f9e46de8e471992f769f6c8fe603d9c671c12472446948c8e57256. Will merge on green.